brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (BROOKLYN-356) The sensor Transformer enricher fails to resolve its targetValue indeterministically.
Date Tue, 01 Nov 2016 11:04:58 GMT

    [ https://issues.apache.org/jira/browse/BROOKLYN-356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15625140#comment-15625140
] 

ASF GitHub Bot commented on BROOKLYN-356:
-----------------------------------------

Github user aledsage commented on a diff in the pull request:

    https://github.com/apache/brooklyn-server/pull/390#discussion_r85909430
  
    --- Diff: core/src/test/java/org/apache/brooklyn/util/core/task/ValueResolverTest.java
---
    @@ -41,6 +49,125 @@ public void setUp() throws Exception {
             super.setUp();
         }
         
    +    public void testTimeoutZero() {
    +        Maybe<String> result = Tasks.resolving(newSleepTask(Duration.TEN_SECONDS,
"foo")).as(String.class).context(app).timeout(Duration.ZERO).getMaybe();
    +        Assert.assertFalse(result.isPresent());
    +    }
    +    
    +    public void testTimeoutBig() {
    +        Maybe<String> result = Tasks.resolving(newSleepTask(Duration.ZERO, "foo")).as(String.class).context(app).timeout(Duration.TEN_SECONDS).getMaybe();
    +        Assert.assertEquals(result.get(), "foo");
    +    }
    +
    +    public void testNoExecutionContextOnCompleted() {
    --- End diff --
    
    I'll add a comment for what I think it means (I just moved this test, rather than adding
it):
    
    ```
        public void testCompletedTaskReturnsResultImmediately() {
            // Call ValueResolver.getMaybe() from this thread, which has no execution context.
            // However, the task has already been submitted and we have waited for it to complete.
            // Therefore the ValueResolver can simply check for task.isDone() and return its
result immediately.
    ```
    
    I'll also add some more tests for this area of the code.


> The sensor Transformer enricher fails to resolve its targetValue indeterministically.
> -------------------------------------------------------------------------------------
>
>                 Key: BROOKLYN-356
>                 URL: https://issues.apache.org/jira/browse/BROOKLYN-356
>             Project: Brooklyn
>          Issue Type: Bug
>            Reporter: Svetoslav Neykov
>
> The sensor {{Transformer}} enricher fails to resolve its {{targetValue}} indeterministically,
especially so on loaded systems. This is especially problematic if sourceSensor/triggerSensors
change infrequently or do not change ever (when using default values).
> Bueprints using the {{Transformer}} behave perfectly fine during development and on test
setups, but will fail on production machines (i.e. under load).
> The code [doing the value resolving|https://github.com/apache/brooklyn-server/blob/b59e7463a9b337c2d0e7931cd420d5bac68d8549/core/src/main/java/org/apache/brooklyn/enricher/stock/Transformer.java#L90-L94]
tries to do so in a non-blocking fashion by spinning a thread to try to resolve and cancelling
it after a short while without guarantees it ever got scheduled to run. It's more likely to
fail when nesting DSLs, for example nesting several levels of {{$brooklyn:formatString}} and
ending with a {{$brooklyn:attributeWhenRready}}. It's a common pattern in moderately complex
blueprints. It needs to schedule a thread for each nesting level thus maximizing the chance
that the value will not be resolved in the allotted time even if resolvabe. This is especially
bad for sensors which don't get updated, for example {{PortAttributeSensorAndConfigKey} set
only when initializing the entity or any config values which are always resolvable.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message