brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aledsage <...@git.apache.org>
Subject [GitHub] brooklyn-server pull request #462: Inherit config default values
Date Mon, 28 Nov 2016 12:33:31 GMT
Github user aledsage commented on a diff in the pull request:

    https://github.com/apache/brooklyn-server/pull/462#discussion_r89772102
  
    --- Diff: core/src/main/java/org/apache/brooklyn/util/core/xstream/ClassRenamingMapper.java
---
    @@ -42,7 +42,7 @@ public ClassRenamingMapper(Mapper wrapped, Map<String, String>
nameToType) {
         
         @Override
         public Class<?> realClass(String elementName) {
    -        Optional<String> elementNameOpt = Reflections.tryFindMappedName(nameToType,
elementName);
    +        Maybe<String> elementNameOpt = Reflections.findMappedNameMaybe(nameToType,
elementName);
    --- End diff --
    
    Why rename this? It was previously following the same naming conventions as guava's `Iterables`
(e.g. `tryFind` versus `find`).
    
    Also, if changing it to a `Maybe` then should we explicitly check for it returning `Maybe.of(null)`,
rather than risking a NPE later?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message