brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aledsage <...@git.apache.org>
Subject [GitHub] brooklyn-server pull request #464: Avoid uncaught exceptions in testOnDoneCa...
Date Mon, 28 Nov 2016 12:04:15 GMT
Github user aledsage commented on a diff in the pull request:

    https://github.com/apache/brooklyn-server/pull/464#discussion_r89768040
  
    --- Diff: core/src/test/java/org/apache/brooklyn/core/mgmt/internal/EntityExecutionManagerTest.java
---
    @@ -68,6 +68,7 @@
     import com.google.common.util.concurrent.Callables;
     
     /** Includes many tests for {@link BrooklynGarbageCollector} */
    +@Test
    --- End diff --
    
    Agreed - seems unnecessary.
    
    It's also a little confusing because some tests in this class are marked with `@Test(groups="Integration")`,
which will (I believe) take precedence over the class' test annotation, but makes people pause
and think.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message