brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sjcorbett <...@git.apache.org>
Subject [GitHub] brooklyn-server pull request #464: Avoid uncaught exceptions in testOnDoneCa...
Date Mon, 28 Nov 2016 11:59:52 GMT
Github user sjcorbett commented on a diff in the pull request:

    https://github.com/apache/brooklyn-server/pull/464#discussion_r89767445
  
    --- Diff: core/src/test/java/org/apache/brooklyn/core/mgmt/internal/EntityExecutionManagerTest.java
---
    @@ -82,18 +83,33 @@ public void testOnDoneCallback() throws InterruptedException {
                 @Override
                 public void onTaskDone(Task<?> task) {
                     Assert.assertTrue(task.isDone());
    -                Assert.assertEquals(task.getUnchecked(), "foo");
    -                completedTasks.put(task, Duration.sinceUtc(task.getEndTimeUtc()));
    -                sema4.release();
    +                Object result = task.getUnchecked();
    +                if(result != null && result.equals("foo")) {
    --- End diff --
    
    Nitpick: add a space between the `if` and the bracket.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message