brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aledsage <...@git.apache.org>
Subject [GitHub] brooklyn-server pull request #468: Added functionality to overwrite private ...
Date Fri, 25 Nov 2016 23:36:38 GMT
Github user aledsage commented on a diff in the pull request:

    https://github.com/apache/brooklyn-server/pull/468#discussion_r89639719
  
    --- Diff: locations/jclouds/src/main/java/org/apache/brooklyn/location/jclouds/JcloudsLocation.java
---
    @@ -3356,6 +3356,12 @@ protected String getPrivateHostname(NodeMetadata node, Optional<HostAndPort>
ssh
         }
         
         protected String getPrivateHostname(NodeMetadata node, Optional<HostAndPort>
sshHostAndPort, Supplier<? extends LoginCredentials> userCredentials, ConfigBag setup)
{
    +        Boolean usePublicEndpointAsPrivateEndpoint = (setup != null) ? setup.get(USE_PUBLIC_ENDPOINT_AS_PRIVATE_ENDPOINT)
: false;
    +        if(usePublicEndpointAsPrivateEndpoint) {
    +            LOG.debug("Overriding private hostname as public hostname because config
"+USE_PUBLIC_ENDPOINT_AS_PRIVATE_ENDPOINT+" is set to true");
    --- End diff --
    
    Minor: prefer `USE_PUBLIC_ENDPOINT_AS_PRIVATE_ENDPOINT.getName()`, because the toString
includes that it is a ConfigKey and its type.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message