brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From geomacy <...@git.apache.org>
Subject [GitHub] brooklyn-server issue #445: Use subnet IP on machine locations that dont imp...
Date Mon, 21 Nov 2016 09:38:09 GMT
Github user geomacy commented on the issue:

    https://github.com/apache/brooklyn-server/pull/445
  
    A bit late perhaps with review comment but, noting that this calls `getSubnetIp()`, is
[this](https://github.com/grkvlt/brooklyn-server/blob/4f3a3da979c4b0a6011bf2f2dcdfa0e3d873d1fa/core/src/main/java/org/apache/brooklyn/core/location/Machines.java#L72)
line meant to read
    ```java
    if (result != null && where instanceof HasNetworkAddresses) {
    ```
    i.e. it goes to the trouble of setting up `result` at line 70 only to potentially overwrite
it at 75, but the code looks like it's meant to be setting `result` based on three possibilities
in a preference order? If that's not intended maybe some explanatory comment would be worthwhile.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message