brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From neykov <...@git.apache.org>
Subject [GitHub] brooklyn-server pull request #440: BROOKLYN-345: persist brooklyn.parameters...
Date Wed, 16 Nov 2016 17:32:04 GMT
Github user neykov commented on a diff in the pull request:

    https://github.com/apache/brooklyn-server/pull/440#discussion_r88287453
  
    --- Diff: utils/common/src/main/java/org/apache/brooklyn/util/time/Time.java ---
    @@ -157,7 +157,7 @@ public static String makeTimeStringRounded(long t, TimeUnit unit)
{
             return makeTimeStringNanoRounded(nanos);
         }
         public static String makeTimeStringRounded(Stopwatch timer) {
    -        return makeTimeStringRounded(timer.elapsed(TimeUnit.MILLISECONDS), TimeUnit.MILLISECONDS);
    +        return (timer == null) ? null : makeTimeStringRounded(timer.elapsed(TimeUnit.MILLISECONDS),
TimeUnit.MILLISECONDS);
    --- End diff --
    
    Can you add `@Nullable`, useful when looking at the signature from the call site.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message