brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aledsage <...@git.apache.org>
Subject [GitHub] brooklyn-server pull request #423: BROOKLYN-382: get-catalog performance imp...
Date Wed, 16 Nov 2016 16:12:52 GMT
Github user aledsage commented on a diff in the pull request:

    https://github.com/apache/brooklyn-server/pull/423#discussion_r88269005
  
    --- Diff: core/src/test/java/org/apache/brooklyn/location/ssh/SshMachineLocationPerformanceTest.java
---
    @@ -79,7 +78,7 @@ public void testConsecutiveSmallCommands() throws Exception {
         }
     
         // Mimics SshSensorAdapter's polling
    -    @Test(groups = {"Integration"})
    +    @Test(groups={"Integration", "Performance"})
    --- End diff --
    
    This does get run if you do `mvn test -Dtest=SshMachineLocationPerformanceTest -PPerformance`,
and gets excluded if you do `-PIntegration`. This is because "Integration" is not excluded
from the "Performance" profile, but "Performance" *is* excluded from the "Integration" profile.
    
    I'll comment more on that against your comment in `parent/pom.xml`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message