brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From neykov <...@git.apache.org>
Subject [GitHub] brooklyn-server pull request #429: BasicJcloudsLocationCustomizer is an Enti...
Date Wed, 16 Nov 2016 12:45:54 GMT
Github user neykov commented on a diff in the pull request:

    https://github.com/apache/brooklyn-server/pull/429#discussion_r88228823
  
    --- Diff: locations/jclouds/src/test/java/org/apache/brooklyn/location/jclouds/BasicJcloudsLocationCustomizerTest.java
---
    @@ -0,0 +1,81 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing,
    + * software distributed under the License is distributed on an
    + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    + * KIND, either express or implied.  See the License for the
    + * specific language governing permissions and limitations
    + * under the License.
    + */
    +
    +package org.apache.brooklyn.location.jclouds;
    +
    +import static org.testng.Assert.assertEquals;
    +import static org.testng.Assert.assertNotNull;
    +import static org.testng.Assert.assertTrue;
    +
    +import java.util.Collection;
    +
    +import org.apache.brooklyn.api.entity.EntitySpec;
    +import org.apache.brooklyn.core.entity.BrooklynConfigKeys;
    +import org.apache.brooklyn.core.test.BrooklynAppUnitTestSupport;
    +import org.apache.brooklyn.core.test.entity.TestEntity;
    +import org.testng.annotations.BeforeMethod;
    +import org.testng.annotations.Test;
    +
    +import com.google.common.collect.ImmutableList;
    +import com.google.common.collect.Iterables;
    +
    +public class BasicJcloudsLocationCustomizerTest extends BrooklynAppUnitTestSupport {
    +
    +    private BasicJcloudsLocationCustomizer testCustomizer;
    +
    +    @BeforeMethod
    +    @Override
    +    public void setUp() throws Exception {
    +        super.setUp();
    +        testCustomizer = new BasicJcloudsLocationCustomizer();
    +    }
    +
    +    @SuppressWarnings("unchecked")
    +    @Test
    +    public void testCustomiserIncluded() {
    +
    +        TestEntity entity = app.createAndManageChild(EntitySpec.create(TestEntity.class)
    +                .addInitializer(testCustomizer));
    +        Object object = entity.config().get(BrooklynConfigKeys.PROVISIONING_PROPERTIES.subKey(
    +                JcloudsLocationConfig.JCLOUDS_LOCATION_CUSTOMIZERS.getName()));
    +        assertNotNull(object, "expected value for customizers in " + entity.config().get(BrooklynConfigKeys.PROVISIONING_PROPERTIES));
    +        assertTrue(object instanceof Collection, "expected collection, got " + object.getClass());
    +        Collection<JcloudsLocationCustomizer> customizers = (Collection<JcloudsLocationCustomizer>)
object;
    +        assertEquals(customizers.size(), 1, "expected single customizer in " + Iterables.toString(customizers));
    +        assertTrue(customizers.contains(testCustomizer), "expected to find testCustomizer
in " + Iterables.toString(customizers));
    +    }
    +
    +    @SuppressWarnings("unchecked")
    +    @Test
    +    public void testCustomizersMerged() {
    +        TestEntity entity = app.createAndManageChild(EntitySpec.create(TestEntity.class)
    +                .addInitializer(testCustomizer)
    +                .configure(
    +                        BrooklynConfigKeys.PROVISIONING_PROPERTIES.subKey(JcloudsLocationConfig.JCLOUDS_LOCATION_CUSTOMIZERS.getName()),
    +                        ImmutableList.of(new BasicJcloudsLocationCustomizer())));
    +        Object object = entity.config().get(BrooklynConfigKeys.PROVISIONING_PROPERTIES.subKey(
    +                JcloudsLocationConfig.JCLOUDS_LOCATION_CUSTOMIZERS.getName()));
    +        assertNotNull(object, "expected value for customizers in " + entity.config().get(BrooklynConfigKeys.PROVISIONING_PROPERTIES));
    +        assertTrue(object instanceof Collection, "expected collection, got " + object.getClass());
    +        Collection<JcloudsLocationCustomizer> customizers = (Collection<JcloudsLocationCustomizer>)
object;
    +        assertEquals(customizers.size(), 2, "expected two customizers in " + Iterables.toString(customizers));
    +        assertTrue(customizers.contains(testCustomizer), "expected to find testCustomizer
in " + Iterables.toString(customizers));
    +    }
    +
    --- End diff --
    
    Thought that there's an `addInitializer` method on the entity, but that's not the case.
    To add an initializer to an existing entity create the initializer and call `apply` on
the entity.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message