brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From neykov <...@git.apache.org>
Subject [GitHub] brooklyn-server pull request #431: SoftwareProcess integration tests: use IN...
Date Mon, 14 Nov 2016 11:28:48 GMT
Github user neykov commented on a diff in the pull request:

    https://github.com/apache/brooklyn-server/pull/431#discussion_r87782693
  
    --- Diff: software/base/src/test/java/org/apache/brooklyn/entity/software/base/VanillaSoftwareProcessIntegrationTest.java
---
    @@ -51,7 +51,7 @@ public void setUp() throws Exception {
             super.setUp();
             localhost = app.getManagementContext().getLocationRegistry().getLocationManaged("localhost");
             
    -        runRecord = Files.createTempFile("testVanillaSoftwareProcess-runRecord", ".txt");
    +        runRecord = Files.createTempFile("testVanillaSoftwareProcess-runRecord-"+Identifiers.makeRandomId(8),
".txt");
    --- End diff --
    
    `createTempFile` is supposed to ensure unique name, is this really needed?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message