brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aledsage <...@git.apache.org>
Subject [GitHub] brooklyn-server pull request #416: Refactor and add to DSL tests
Date Tue, 08 Nov 2016 15:39:52 GMT
Github user aledsage commented on a diff in the pull request:

    https://github.com/apache/brooklyn-server/pull/416#discussion_r87014553
  
    --- Diff: camp/camp-brooklyn/src/test/java/org/apache/brooklyn/camp/brooklyn/DslAndRebindYamlTest.java
---
    @@ -61,58 +56,41 @@
     
     import com.google.common.collect.Iterables;
     import com.google.common.collect.Lists;
    -import com.google.common.io.Files;
     
     @Test
    -public class DslAndRebindYamlTest extends AbstractYamlTest {
    +public class DslAndRebindYamlTest extends AbstractYamlRebindTest {
    --- End diff --
    
    The `AbstractYamlRebindTest` does the rebind correctly - it makes sure the `mgmt` field
is updated on rebind, so subsequent provisioning uses the new application context. Before
this, `testDslSensorFromClass` was not doing what you'd expect - the second call returned
the app from the first call to `doTestOnEntityWithSensor`, so the subsequent assertions weren't
useful.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message