brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tbouron <...@git.apache.org>
Subject [GitHub] brooklyn-server pull request #414: Improvement of TestHttpCall entity
Date Tue, 08 Nov 2016 11:42:32 GMT
Github user tbouron commented on a diff in the pull request:

    https://github.com/apache/brooklyn-server/pull/414#discussion_r86972493
  
    --- Diff: test-framework/src/main/java/org/apache/brooklyn/test/framework/TestHttpCall.java
---
    @@ -32,9 +36,34 @@
         @SetFromFlag(nullable = false)
         ConfigKey<String> TARGET_URL = ConfigKeys.newStringConfigKey("url", "URL to
test");
     
    +    @SetFromFlag(nullable = false)
    +    ConfigKey<HttpMethod> TARGET_METHOD = ConfigKeys.builder(HttpMethod.class)
    +            .name("method")
    +            .description("Method to request the URL: GET, POST, PUT, DELETE, etc")
    +            .defaultValue(HttpMethod.GET)
    +            .build();
    +
    +    @SetFromFlag
    --- End diff --
    
    But if I remove the `@SetFromFlag`, we won't be able to set this config key outside the
`brooklyn.config` block, isn't it @aledsage ?
    
    I also keep them as it was the "standard" across the test entities


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message