brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aledsage <...@git.apache.org>
Subject [GitHub] brooklyn-server pull request #414: Improvement of TestHttpCall entity
Date Tue, 08 Nov 2016 11:37:46 GMT
Github user aledsage commented on a diff in the pull request:

    https://github.com/apache/brooklyn-server/pull/414#discussion_r86971858
  
    --- Diff: test-framework/src/main/java/org/apache/brooklyn/test/framework/TestHttpCallImpl.java
---
    @@ -50,19 +55,25 @@
          */
         public void start(Collection<? extends Location> locations) {
             String url = null;
    +        HttpMethod method = null;
    --- End diff --
    
    Minor; feel free to ignore :-)
    We only declare `url` above because the variable is needed in the catch block for a nicer
error message. I'd declare these variables in-line, rather than outside of the try block,
unless we also want to log any of them in the catch error message.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message