brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From geomacy <...@git.apache.org>
Subject [GitHub] brooklyn-server issue #406: Fix app.stop so doesn’t go on-fire briefly
Date Mon, 07 Nov 2016 15:00:58 GMT
Github user geomacy commented on the issue:

    https://github.com/apache/brooklyn-server/pull/406
  
    👍  LGTM. The change makes sense according to the description above.  
    
    On the question of reproducing this, I wasn't able to reproduce the test failure prior
with master at date of 26th October (34eab17).  I caught up with master today and was able
to get a couple of test failures by running 500 iterations of `testStopLatchBlocks`.   It's
possible that recent changes have affected the visibility of the race that @aledsage mentions
above.   
    
    Having pulled and merged this PR, however, I was able to run 1000 iterations without any
failures. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message