brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aledsage <...@git.apache.org>
Subject [GitHub] brooklyn-server pull request #408: Use actual config key if available in DSL
Date Mon, 07 Nov 2016 09:36:01 GMT
Github user aledsage commented on a diff in the pull request:

    https://github.com/apache/brooklyn-server/pull/408#discussion_r86738440
  
    --- Diff: camp/camp-brooklyn/src/main/java/org/apache/brooklyn/camp/brooklyn/spi/dsl/methods/DslComponent.java
---
    @@ -257,7 +260,7 @@ public EntityId(DslComponent component) {
             @Override
             public Maybe<Object> getImmediately() {
                 Maybe<Entity> targetEntityMaybe = component.getImmediately();
    -            if (targetEntityMaybe.isAbsent()) return Maybe.absent("Target entity not
available");
    +            if (targetEntityMaybe.isAbsentOrNull()) return Maybe.absent("Target entity
not available");
    --- End diff --
    
    As above: this is changing the semantics of `getImmediately` compared to `get`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message