Mailing-List: contact dev-help@brooklyn.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@brooklyn.apache.org
From: geomacy <git@git.apache.org>
To: dev@brooklyn.apache.org
Reply-To: dev@brooklyn.apache.org
References: <git-pr-392-brooklyn-server@git.apache.org>
In-Reply-To: <git-pr-392-brooklyn-server@git.apache.org>
Subject: [GitHub] brooklyn-server pull request #392: [WIP] $brooklyn:self().template("freemark...
Content-Type: text/plain
Message-Id: <20161026104700.78A1BEC22D@git1-us-west.apache.org>
Date: Wed, 26 Oct 2016 10:47:00 +0000 (UTC)
archived-at: Wed, 26 Oct 2016 10:47:02 -0000

Github user geomacy commented on a diff in the pull request:

    https://github.com/apache/brooklyn-server/pull/392#discussion_r85094334
  
    --- Diff: core/src/test/java/org/apache/brooklyn/util/core/text/TemplateProcessorTest.java ---
    @@ -71,6 +71,15 @@ public void testEntityConfig() {
         }
         
         @Test
    +    public void testDsl() {
    +        TestEntity entity = app.createAndManageChild(EntitySpec.create(TestEntity.class)
    +                .configure(TestEntity.CONF_NAME, "myval"));
    +        String templateContents = "${brooklyn(\"id\")}";
    --- End diff --
    
    Surely should be 
    ```java
            String templateContents = "${config['" + TestEntity.CONF_NAME.getName() + "']}";
    ```
    As written this test breaks for me.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---