brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sjcorbett <>
Subject [GitHub] brooklyn-server pull request #393: Lifecycle fixes
Date Mon, 24 Oct 2016 10:49:42 GMT
GitHub user sjcorbett opened a pull request:

    Lifecycle fixes

    Fixes a handful of surprising behaviours in AbstractApplication, DynamicGroup and BasicStartable.

You can merge this pull request into a Git repository by running:

    $ git pull fixes

Alternatively you can review and apply these changes as the patch at:

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #393
commit 15aa6ff8b572da0142a905679714fbddc9a8ff58
Author: Sam Corbett <>
Date:   2016-10-20T14:56:01Z

    DynamicGroup wraps entity filters in a same-app check

commit 48c98abf36cadfa3a5837ab16a37709783e20826
Author: Sam Corbett <>
Date:   2016-10-20T15:40:48Z

    BasicStartable is on fire if any of its children are on fire
    And follow the same pattern as DynamicCluster for setting expected
    state when starting and stopping.

commit 6e1a31872efbb3f9a991fcce83a875b3d89aa85f
Author: Sam Corbett <>
Date:   2016-10-20T15:42:02Z

    AbstractApplication recovers from failure of children
    Previously if a problem with child start up was fixed the application
    would only recover if its start method was re-run.

commit eedf276e8c75bf7a5e53580e3c4b2ed0c742da4e
Author: Sam Corbett <>
Date:   2016-10-24T10:43:15Z

    Handle pre/post/launch errors in AbstractSoftwareProcessDriver restart
    Previously if any phase errored (e.g. a post-launch comment exited with a
    non-zero code) the entity would be stuck in the 'starting' state.

commit 1ed02b28a285d83050049973df559a34f04e9a79
Author: Sam Corbett <>
Date:   2016-10-24T10:43:34Z

    Asserts.expectedFailureOfType requires at least one type


If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message