brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (BROOKLYN-230) `br application <id>` fails when app has no locations
Date Mon, 24 Oct 2016 16:42:58 GMT

    [ https://issues.apache.org/jira/browse/BROOKLYN-230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15602531#comment-15602531
] 

ASF GitHub Bot commented on BROOKLYN-230:
-----------------------------------------

GitHub user sjcorbett opened a pull request:

    https://github.com/apache/brooklyn-client/pull/30

    br app only outputs location details when the app has a location

    Fixes https://issues.apache.org/jira/browse/BROOKLYN-230.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/sjcorbett/brooklyn-client brooklyn-230

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/brooklyn-client/pull/30.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #30
    
----
commit bcc1360690cefb4b677a9556117e6d3400dac71d
Author: Sam Corbett <sam.corbett@cloudsoftcorp.com>
Date:   2016-10-24T16:40:53Z

    Only output location details when the app has a location
    
    Fixes https://issues.apache.org/jira/browse/BROOKLYN-230

----


> `br application <id>` fails when app has no locations
> -----------------------------------------------------
>
>                 Key: BROOKLYN-230
>                 URL: https://issues.apache.org/jira/browse/BROOKLYN-230
>             Project: Brooklyn
>          Issue Type: Bug
>            Reporter: Aled Sage
>
> Using the {{br}} CLI, we tried retrieving an application that did not have a location.
It gave the error below:
> {noformat}
> Aleds-MacBook-Pro:training aled $ br application H8pDTFcH
> panic: runtime error: index out of range
> goroutine 1 [running]:
> github.com/brooklyncentral/brooklyn-cli/commands.(*Application).show(0xc820030068, 0x7fff5fbff307,
0x8)
>     /Users/david/workspaces/go/src/github.com/brooklyncentral/brooklyn-cli/commands/application.go:63
+0xe74
> github.com/brooklyncentral/brooklyn-cli/commands.(*Application).Run(0xc820030068, 0x0,
0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, ...)
>     /Users/david/workspaces/go/src/github.com/brooklyncentral/brooklyn-cli/commands/application.go:43
+0x21d
> github.com/brooklyncentral/brooklyn-cli/command_runner.ConcreteRunner.RunCmdByName(0x801bb0,
0xc820017070, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, ...)
>     /Users/david/workspaces/go/src/github.com/brooklyncentral/brooklyn-cli/command_runner/runner.go:31
+0xe7
> github.com/brooklyncentral/brooklyn-cli/command_runner.(*ConcreteRunner).RunCmdByName(0xc820018300,
0x3ee080, 0xb, 0xc8200777a0, 0x0, 0x0)
>     <autogenerated>:1 +0xe0
> github.com/brooklyncentral/brooklyn-cli/app.getCommand.func1(0xc8200777a0)
>     /Users/david/workspaces/go/src/github.com/brooklyncentral/brooklyn-cli/app/app.go:54
+0x57
> github.com/codegangsta/cli.Command.Run(0x3ee080, 0xb, 0x0, 0x0, 0xc82000b290, 0x3, 0x3,
0xc82000eb60, 0x14, 0x458800, ...)
>     /Users/david/workspaces/go/src/github.com/codegangsta/cli/command.go:131 +0x107e
> github.com/codegangsta/cli.(*App).Run(0xc820077560, 0xc82000b230, 0x3, 0x3, 0x0, 0x0)
>     /Users/david/workspaces/go/src/github.com/codegangsta/cli/app.go:175 +0xfff
> main.main()
>     /Users/david/workspaces/go/src/github.com/brooklyncentral/brooklyn-cli/br/brooklyn.go:41
+0x84e
> goroutine 17 [IO wait]:
> net.runtime_pollWait(0x802d58, 0x72, 0xc8200161a0)
>     /usr/local/Cellar/go/1.5.1/libexec/src/runtime/netpoll.go:157 +0x60
> net.(*pollDesc).Wait(0xc8200ec0d0, 0x72, 0x0, 0x0)
>     /usr/local/Cellar/go/1.5.1/libexec/src/net/fd_poll_runtime.go:73 +0x3a
> net.(*pollDesc).WaitRead(0xc8200ec0d0, 0x0, 0x0)
>     /usr/local/Cellar/go/1.5.1/libexec/src/net/fd_poll_runtime.go:78 +0x36
> net.(*netFD).Read(0xc8200ec070, 0xc8200fc000, 0x1000, 0x1000, 0x0, 0x7fd050, 0xc8200161a0)
>     /usr/local/Cellar/go/1.5.1/libexec/src/net/fd_unix.go:232 +0x23a
> net.(*conn).Read(0xc8200f0008, 0xc8200fc000, 0x1000, 0x1000, 0x0, 0x0, 0x0)
>     /usr/local/Cellar/go/1.5.1/libexec/src/net/net.go:172 +0xe4
> net/http.noteEOFReader.Read(0x83d180, 0xc8200f0008, 0xc8200b8058, 0xc8200fc000, 0x1000,
0x1000, 0x0, 0x0, 0x0)
>     /usr/local/Cellar/go/1.5.1/libexec/src/net/http/transport.go:1370 +0x67
> net/http.(*noteEOFReader).Read(0xc8200e8200, 0xc8200fc000, 0x1000, 0x1000, 0x0, 0x0,
0x0)
>     <autogenerated>:126 +0xd0
> bufio.(*Reader).fill(0xc8200fa060)
>     /usr/local/Cellar/go/1.5.1/libexec/src/bufio/bufio.go:97 +0x1e9
> bufio.(*Reader).Peek(0xc8200fa060, 0x1, 0x0, 0x0, 0x0, 0x0, 0x0)
>     /usr/local/Cellar/go/1.5.1/libexec/src/bufio/bufio.go:132 +0xcc
> net/http.(*persistConn).readLoop(0xc8200b8000)
>     /usr/local/Cellar/go/1.5.1/libexec/src/net/http/transport.go:876 +0xf7
> created by net/http.(*Transport).dialConn
>     /usr/local/Cellar/go/1.5.1/libexec/src/net/http/transport.go:685 +0xc78
> goroutine 18 [select]:
> net/http.(*persistConn).writeLoop(0xc8200b8000)
>     /usr/local/Cellar/go/1.5.1/libexec/src/net/http/transport.go:1009 +0x40c
> created by net/http.(*Transport).dialConn
>     /usr/local/Cellar/go/1.5.1/libexec/src/net/http/transport.go:686 +0xc9d
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message