brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From geomacy <...@git.apache.org>
Subject [GitHub] brooklyn-server pull request #370: ProxyEffector
Date Tue, 11 Oct 2016 13:55:18 GMT
Github user geomacy commented on a diff in the pull request:

    https://github.com/apache/brooklyn-server/pull/370#discussion_r82797342
  
    --- Diff: core/src/test/java/org/apache/brooklyn/core/effector/ProxyEffectorTest.java
---
    @@ -0,0 +1,88 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing,
    + * software distributed under the License is distributed on an
    + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    + * KIND, either express or implied.  See the License for the
    + * specific language governing permissions and limitations
    + * under the License.
    + */
    +
    +package org.apache.brooklyn.core.effector;
    +
    +import static org.testng.Assert.assertEquals;
    +
    +import org.apache.brooklyn.api.entity.EntitySpec;
    +import org.apache.brooklyn.core.entity.Entities;
    +import org.apache.brooklyn.core.entity.EntityInternal;
    +import org.apache.brooklyn.core.test.BrooklynAppUnitTestSupport;
    +import org.apache.brooklyn.core.test.entity.TestEntity;
    +import org.apache.brooklyn.entity.stock.BasicEntity;
    +import org.apache.brooklyn.test.Asserts;
    +import org.apache.brooklyn.util.collections.MutableMap;
    +import org.apache.brooklyn.util.time.Duration;
    +import org.testng.annotations.Test;
    +
    +import com.google.common.collect.ImmutableMap;
    +
    +public class ProxyEffectorTest extends BrooklynAppUnitTestSupport {
    +
    +    @Test
    +    public void testHappyPath() {
    +        TestEntity a = app.createAndManageChild(EntitySpec.create(TestEntity.class));
    +        ProxyEffector proxyEffector = new ProxyEffector(ImmutableMap.of(
    +                AddEffector.EFFECTOR_NAME, "proxy-effector",
    +                ProxyEffector.TARGET_ENTITY, a,
    +                ProxyEffector.TARGET_EFFECTOR_NAME, "identityEffector"));
    +        // BasicEntity doesn't have an identityEffector.
    +        EntityInternal b = Entities.deproxy(app.createAndManageChild(EntitySpec.create(BasicEntity.class)
    +                .addInitializer(proxyEffector)));
    +        Object output = b.invoke(b.getEffector("proxy-effector"), ImmutableMap.of("arg",
"value"))
    --- End diff --
    
    Sorry yes made a bit of a mental leap and didn't explain it too well - so at first glance
I'd thought these were entities in two separate apps; now ok they are not, but it did immediately
prompt the question of what if they were?  I could imagine what I think are useful use-cases,
e.g. have one app with a Management Information System of some sort that has to collect information
about all the parts of your overall infrastructure. Then other apps that are created separately,
perhaps much later, can still be configured to call a proxy effector pointing at the MIS in
the completely different application. On the other hand allowing apps to invoke effectors
on other apps' entities may be a security risk - maybe for isolation purposes it's better
to forbid this?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message