brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From neykov <...@git.apache.org>
Subject [GitHub] brooklyn-server pull request #365: [BROOKLYN-356] Transformer value resolver...
Date Tue, 11 Oct 2016 05:54:51 GMT
Github user neykov commented on a diff in the pull request:

    https://github.com/apache/brooklyn-server/pull/365#discussion_r82728162
  
    --- Diff: core/src/main/java/org/apache/brooklyn/util/core/task/BasicExecutionManager.java
---
    @@ -507,23 +517,14 @@ public T call() {
                 try {
                     T result = null;
                     Throwable error = null;
    -                String oldThreadName = Thread.currentThread().getName();
                     try {
    -                    if (RENAME_THREADS) {
    --- End diff --
    
    Correct. Details in the commit message:
    ```
    Remove duplicate thread renaming
    
    The code in beforeStartAtomicTask overrides the value set here. Keeping the other one
as it's called for scheduled tasks as well.
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message