brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aledsage <...@git.apache.org>
Subject [GitHub] brooklyn-server pull request #371: One instance of customizer at each custom...
Date Thu, 06 Oct 2016 10:00:11 GMT
Github user aledsage commented on a diff in the pull request:

    https://github.com/apache/brooklyn-server/pull/371#discussion_r82154264
  
    --- Diff: locations/jclouds/src/main/java/org/apache/brooklyn/location/jclouds/JcloudsLocation.java
---
    @@ -409,7 +409,7 @@ protected CloudMachineNamer getCloudMachineNamer(ConfigBag config)
{
             }
         }
     
    -    protected Collection<JcloudsLocationCustomizer> getCustomizers(ConfigBag setup)
{
    +    public Collection<JcloudsLocationCustomizer> getCustomizers(ConfigBag setup)
{
    --- End diff --
    
    I'm slightly uncomfortable about this becoming public - but I see why you had to do it,
to let it be called by `CloudExplorerSupport.java`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message