brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aledsage <...@git.apache.org>
Subject [GitHub] brooklyn-server pull request #365: [BROOKLYN-356] Transformer value resolver...
Date Wed, 05 Oct 2016 09:21:57 GMT
Github user aledsage commented on a diff in the pull request:

    https://github.com/apache/brooklyn-server/pull/365#discussion_r81932394
  
    --- Diff: core/src/main/java/org/apache/brooklyn/util/core/task/BasicExecutionManager.java
---
    @@ -757,9 +758,23 @@ protected void internalBeforeStart(Map<?,?> flags, Task<?>
task) {
                 PerThreadCurrentTaskHolder.perThreadCurrentTask.set(task);
                 ((TaskInternal<?>)task).setStartTimeUtc(System.currentTimeMillis());
             }
    +
    +        jitterThreadStart(task);
    +
             invokeCallback(flags.get("newTaskStartCallback"), task);
         }
     
    +    private void jitterThreadStart(Task<?> task) {
    --- End diff --
    
    Great idea!
    
    I wonder if we should make it non-static so it can be set by a test, and unset in its
`tearDown` method. But let's go with static. For now, we can use it by setting the system
property when doing `mvn clean install`. 
    
    Once we've fixed (most of) the failures that it exposes, then we can think about enabling
it for some tests in jenkins - for regression testing purposes. But we want jenkins to be
deterministic!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message