Return-Path: <dev-return-19115-archive-asf-public=cust-asf.ponee.io@brooklyn.apache.org>
X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io
Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io
Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183])
	by cust-asf2.ponee.io (Postfix) with ESMTP id 62936200B9F
	for <archive-asf-public-internal@cust-asf2.ponee.io>; Mon, 26 Sep 2016 18:22:22 +0200 (CEST)
Received: by cust-asf.ponee.io (Postfix)
	id 615CA160AC8; Mon, 26 Sep 2016 16:22:22 +0000 (UTC)
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by cust-asf.ponee.io (Postfix) with SMTP id AD7D3160AE5
	for <archive-asf-public@cust-asf.ponee.io>; Mon, 26 Sep 2016 18:22:21 +0200 (CEST)
Received: (qmail 4340 invoked by uid 500); 26 Sep 2016 16:22:20 -0000
Mailing-List: contact dev-help@brooklyn.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@brooklyn.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@brooklyn.apache.org>
List-Post: <mailto:dev@brooklyn.apache.org>
List-Id: <dev.brooklyn.apache.org>
Reply-To: dev@brooklyn.apache.org
Delivered-To: mailing list dev@brooklyn.apache.org
Received: (qmail 4236 invoked by uid 99); 26 Sep 2016 16:22:20 -0000
Received: from arcas.apache.org (HELO arcas) (140.211.11.28)
    by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 26 Sep 2016 16:22:20 +0000
Received: from arcas.apache.org (localhost [127.0.0.1])
	by arcas (Postfix) with ESMTP id AF9B62C2A6A
	for <dev@brooklyn.apache.org>; Mon, 26 Sep 2016 16:22:20 +0000 (UTC)
Date: Mon, 26 Sep 2016 16:22:20 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: dev@brooklyn.apache.org
Message-ID: <JIRA.13007546.1474891741000.664997.1474906940716@Atlassian.JIRA>
In-Reply-To: <JIRA.13007546.1474891741000@Atlassian.JIRA>
References: <JIRA.13007546.1474891741000@Atlassian.JIRA> <JIRA.13007546.1474891741106@arcas>
Subject: [jira] [Commented] (BROOKLYN-350) Upstream yum repos for
 PostgresSQL started to enforce HTTPS
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394
archived-at: Mon, 26 Sep 2016 16:22:22 -0000


    [ https://issues.apache.org/jira/browse/BROOKLYN-350?page=3Dcom.atlassi=
an.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D15=
523508#comment-15523508 ]=20

ASF GitHub Bot commented on BROOKLYN-350:
-----------------------------------------

Github user bostko commented on a diff in the pull request:

    https://github.com/apache/brooklyn-library/pull/64#discussion_r80513931
 =20
    --- Diff: software/database/src/main/java/org/apache/brooklyn/entity/da=
tabase/postgresql/PostgreSqlNode.java ---
    @@ -52,13 +52,17 @@
     public interface PostgreSqlNode extends SoftwareProcess, HasShortName,=
 DatastoreCommon, DatabaseNode {
        =20
         @SetFromFlag("version")
    -    ConfigKey<String> SUGGESTED_VERSION =3D ConfigKeys.newConfigKeyWit=
hDefault(SoftwareProcess.SUGGESTED_VERSION, "9.3-1");//"9.1-4");
    +    ConfigKey<String> SUGGESTED_VERSION =3D ConfigKeys.newConfigKeyWit=
hDefault(SoftwareProcess.SUGGESTED_VERSION, "9.3-3");//"9.1-4");
    =20
         @SetFromFlag("configFileUrl")
         ConfigKey<String> CONFIGURATION_FILE_URL =3D ConfigKeys.newStringC=
onfigKey(
                 "postgresql.config.file.url", "URL where PostgreSQL config=
uration file can be found; "
                     + "if not supplied the blueprint uses the default and =
customises it");
    =20
    +    @SetFromFlag("curlCommand")
    +    ConfigKey<String> CURL_COMMAND =3D ConfigKeys.newStringConfigKey(
    +            "curl.command", "cURL comamnd to be used. It follows locat=
ion redirects by default (added -L parameter)", "curl -L");
    --- End diff --
   =20
    Strange config usage of =D0=B0 parameter.
    Very important to add a sentence about checking the parameter usage in =
Java code.
   =20
    I would rather declare a CURL_COMMAND_OPTIONS parameter and put the sin=
gle `-L` as a default value.


> Upstream yum repos for PostgresSQL started to enforce HTTPS
> -----------------------------------------------------------
>
>                 Key: BROOKLYN-350
>                 URL: https://issues.apache.org/jira/browse/BROOKLYN-350
>             Project: Brooklyn
>          Issue Type: Dependency upgrade
>            Reporter: Yavor Yanchev
>
> The upstream YUM repos [1] provided by the PostgreSQL project started to =
enforce HTTPS.
> The PostgreSqlSshDriver uses curl to download RPMs from the upstream repo=
 URL, but fails because it is redirected to the HTTPS location using a stan=
dard 301 header and curl is not instructed to follow the redirects.
> Example curl output
> {code}
> < HTTP/1.1 301 Moved Permanently
> < Location: https://yum.postgresql.org/9.4/redhat/rhel-6-x86_64/pgdg-cent=
os94-9.4-2.noarch.rpm
> {code}
> If curl is instructed to follow the redirects with -L (--location) option=
 the download will be successful=20
> [1] http://yum.postgresql.org



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)