Mailing-List: contact dev-help@brooklyn.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@brooklyn.apache.org
From: neykov <git@git.apache.org>
To: dev@brooklyn.apache.org
Reply-To: dev@brooklyn.apache.org
References: <git-pr-34-brooklyn-ui@git.apache.org>
In-Reply-To: <git-pr-34-brooklyn-ui@git.apache.org>
Subject: [GitHub] brooklyn-ui pull request #34: Use new pinned and constraints flag returned b...
Content-Type: text/plain
Message-Id: <20160930163000.ED780DFD4C@git1-us-west.apache.org>
Date: Fri, 30 Sep 2016 16:30:00 +0000 (UTC)
archived-at: Fri, 30 Sep 2016 16:30:02 -0000

Github user neykov commented on a diff in the pull request:

    https://github.com/apache/brooklyn-ui/pull/34#discussion_r81372539
  
    --- Diff: src/main/webapp/assets/js/view/application-add-wizard.js ---
    @@ -680,10 +680,12 @@ define([
                     this.$('.required-config-loading').hide()
                     if (catalogEntryItem!=null && catalogEntryItem.config!=null) {
                         var that = this
    -                    _.each(catalogEntryItem.config, function (cfg) {
    -                        if (cfg.priority !== undefined) {
    +                    _.chain(catalogEntryItem.config).sortBy(function (cfg){
    +                        return !isNaN(cfg.priority) ? cfg.priority : 99999;
    +                    }).each(function (cfg) {
    +                        if (cfg.pinned === true || (cfg.contraints.indexOf('required') > -1 && typeof cfg.defaultValue === 'string' && cfg.defaultValue === '')) {
    --- End diff --
    
    Agree, that's my point.
    `defaultValue == null` on the server side is serialized as missing (`undefined`) on the wire.
    Which means that `cfg.contraints.indexOf('required') > -1 && typeof cfg.defaultValue === 'string' && cfg.defaultValue === ''` will be `false` for `undefined`. So it will not be shown, even if required.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---