Mailing-List: contact dev-help@brooklyn.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@brooklyn.apache.org
From: tbouron <git@git.apache.org>
To: dev@brooklyn.apache.org
Reply-To: dev@brooklyn.apache.org
References: <git-pr-358-brooklyn-server@git.apache.org>
In-Reply-To: <git-pr-358-brooklyn-server@git.apache.org>
Subject: [GitHub] brooklyn-server pull request #358: Allow REST API to return the config key's...
Content-Type: text/plain
Message-Id: <20160929121352.BB348E0230@git1-us-west.apache.org>
Date: Thu, 29 Sep 2016 12:13:52 +0000 (UTC)
archived-at: Thu, 29 Sep 2016 12:13:54 -0000

Github user tbouron commented on a diff in the pull request:

    https://github.com/apache/brooklyn-server/pull/358#discussion_r81122413
  
    --- Diff: core/src/main/java/org/apache/brooklyn/core/objs/BasicSpecParameter.java ---
    @@ -247,17 +248,17 @@ public String toString() {
                     .name(name)
                     .description(description)
                     .defaultValue(defaultValue)
    -                .constraint(constraints)
    +                .constraints(constraints)
                     .runtimeInheritance(parentInheritance)
                     .typeInheritance(typeInheritance);
    -            
    +
                 if (PortRange.class.equals(typeToken.getRawType())) {
                     sensorType = new PortAttributeSensorAndConfigKey(builder);
                     configType = ((HasConfigKey)sensorType).getConfigKey();
                 } else {
                     configType = builder.build();
                 }
    -            return new BasicSpecParameter(Objects.firstNonNull(label, name), true, configType, sensorType);
    +            return new BasicSpecParameter(Objects.firstNonNull(label, name), Objects.firstNonNull(pinned, Boolean.FALSE), configType, sensorType);
    --- End diff --
    
    I prefer to comply with the "standard". I'll update it


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---