Return-Path: <dev-return-18917-archive-asf-public=cust-asf.ponee.io@brooklyn.apache.org>
X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io
Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io
Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183])
	by cust-asf2.ponee.io (Postfix) with ESMTP id F1EAF200B89
	for <archive-asf-public-internal@cust-asf2.ponee.io>; Wed, 21 Sep 2016 16:15:09 +0200 (CEST)
Received: by cust-asf.ponee.io (Postfix)
	id F082E160ADB; Wed, 21 Sep 2016 14:15:09 +0000 (UTC)
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by cust-asf.ponee.io (Postfix) with SMTP id BA9A4160ACF
	for <archive-asf-public@cust-asf.ponee.io>; Wed, 21 Sep 2016 16:15:08 +0200 (CEST)
Received: (qmail 56346 invoked by uid 500); 21 Sep 2016 14:15:07 -0000
Mailing-List: contact dev-help@brooklyn.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@brooklyn.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@brooklyn.apache.org>
List-Post: <mailto:dev@brooklyn.apache.org>
List-Id: <dev.brooklyn.apache.org>
Reply-To: dev@brooklyn.apache.org
Delivered-To: mailing list dev@brooklyn.apache.org
Received: (qmail 56335 invoked by uid 99); 21 Sep 2016 14:15:07 -0000
Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23)
    by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 21 Sep 2016 14:15:07 +0000
Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33)
	id 7FA8AE0061; Wed, 21 Sep 2016 14:15:07 +0000 (UTC)
From: neykov <git@git.apache.org>
To: dev@brooklyn.apache.org
Reply-To: dev@brooklyn.apache.org
References: <git-pr-300-brooklyn-server@git.apache.org>
In-Reply-To: <git-pr-300-brooklyn-server@git.apache.org>
Subject: [GitHub] brooklyn-server pull request #300: Location DSL Updates
Content-Type: text/plain
Message-Id: <20160921141507.7FA8AE0061@git1-us-west.apache.org>
Date: Wed, 21 Sep 2016 14:15:07 +0000 (UTC)
archived-at: Wed, 21 Sep 2016 14:15:10 -0000

Github user neykov commented on a diff in the pull request:

    https://github.com/apache/brooklyn-server/pull/300#discussion_r79842987
  
    --- Diff: core/src/main/java/org/apache/brooklyn/entity/group/DynamicFabric.java ---
    @@ -67,9 +69,7 @@
         public static final AttributeSensor<Lifecycle> SERVICE_STATE_ACTUAL = Attributes.SERVICE_STATE_ACTUAL;
     
         public void setMemberSpec(EntitySpec<?> memberSpec);
    -    
    -    public void setFactory(EntityFactory<?> factory);
    -    
    --- End diff --
    
    Should we go through a deprecation cycle here?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---