brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From geomacy <>
Subject [GitHub] brooklyn-server pull request #336: For review: Catalog update
Date Tue, 20 Sep 2016 15:56:40 GMT
GitHub user geomacy opened a pull request:

    For review: Catalog update

    For AMP-982, work in progress.
    Updates BrooklynObject and BrooklynObjectSpec to support nested catalogItemIds.
    ### TODO:
    * doesn't include changes to persistence to allow the nested item ids to be persisted
and retrieved during rebind
    * Need to review what changes may be needed to EntityTransientCopyInternal.
    * Looks like catalogItemIdIfNotNull can be removed.
    ### Things to review
    Everything, really; but some things I made a note of particularly
    * review places where setCatalogItemIdIfNotNull has been replaced with nestCatalogItemIds
and see if they make sense from a sanity viewpoint
    * review use of setCatalogItemIds()

You can merge this pull request into a Git repository by running:

    $ git pull catalog-update

Alternatively you can review and apply these changes as the patch at:

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #336
commit 63408e1ac5cf4383824e1138cf155746731c1236
Author: Geoff Macartney <>
Date:   2016-09-14T13:44:14Z

    Osgi loader change

commit d28ea3c56b53ff9d3c250d931325cf487a73baf6
Author: Geoff Macartney <>
Date:   2016-09-19T13:22:43Z

    Add nested catalog item ids to AbstractBrooklynObjectSpec.

commit d021c61a2f9c775816f771eabb719722e2226b57
Author: Geoff Macartney <>
Date:   2016-09-20T10:16:36Z

    Add catalog item super id support.

commit 7dff236abb1e044744043006bea882cdc0630f57
Author: Geoff Macartney <>
Date:   2016-09-20T14:51:47Z

    Fixes to get CatalogYamlEntityTest.testCatalogItemIdInReferencedItems working.
    Haven't re-run all unit tests yet.


If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message