brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tbouron <...@git.apache.org>
Subject [GitHub] brooklyn-ui pull request #34: Use new pinned and constraints flag returned b...
Date Fri, 30 Sep 2016 15:58:57 GMT
Github user tbouron commented on a diff in the pull request:

    https://github.com/apache/brooklyn-ui/pull/34#discussion_r81367055
  
    --- Diff: src/main/webapp/assets/js/view/application-add-wizard.js ---
    @@ -680,10 +680,12 @@ define([
                     this.$('.required-config-loading').hide()
                     if (catalogEntryItem!=null && catalogEntryItem.config!=null)
{
                         var that = this
    -                    _.each(catalogEntryItem.config, function (cfg) {
    -                        if (cfg.priority !== undefined) {
    +                    _.chain(catalogEntryItem.config).sortBy(function (cfg){
    +                        return !isNaN(cfg.priority) ? cfg.priority : 99999;
    +                    }).each(function (cfg) {
    +                        if (cfg.pinned === true || (cfg.contraints.indexOf('required')
> -1 && typeof cfg.defaultValue === 'string' && cfg.defaultValue === ''))
{
    --- End diff --
    
    > This doesn't handle defaultValue == null (or is null converted to '' somethere?).
    Could do
    
    This would never happens as the REST API returns the `Predicate.toString()`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message