brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tbouron <...@git.apache.org>
Subject [GitHub] brooklyn-server pull request #358: Allow REST API to return the pinned confi...
Date Thu, 29 Sep 2016 17:22:27 GMT
Github user tbouron commented on a diff in the pull request:

    https://github.com/apache/brooklyn-server/pull/358#discussion_r81188720
  
    --- Diff: core/src/main/java/org/apache/brooklyn/core/config/BasicConfigKey.java ---
    @@ -184,7 +192,7 @@ public String getDescription() {
         protected boolean reconfigurable;
         protected ConfigInheritance typeInheritance;
         protected ConfigInheritance runtimeInheritance;
    -    protected Predicate<? super T> constraint;
    +    protected List<Predicate<? super T>> constraints;
    --- End diff --
    
    But this is the whole point of this change, expose the constraints as a list of string
on the REST API. I thought about doing the change you are suggesting @neykov (looking into
the `Predicates.and()`) but there is no way to get back the underlying predicates.
    Reverting would mean to support only one predicate at a time which is a contradiction
with the current YAML implementation (can specify more than one)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message