brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From neykov <...@git.apache.org>
Subject [GitHub] brooklyn-server pull request #358: Allow REST API to return the pinned confi...
Date Thu, 29 Sep 2016 16:56:54 GMT
Github user neykov commented on a diff in the pull request:

    https://github.com/apache/brooklyn-server/pull/358#discussion_r81183657
  
    --- Diff: core/src/main/java/org/apache/brooklyn/core/config/BasicConfigKey.java ---
    @@ -184,7 +192,7 @@ public String getDescription() {
         protected boolean reconfigurable;
         protected ConfigInheritance typeInheritance;
         protected ConfigInheritance runtimeInheritance;
    -    protected Predicate<? super T> constraint;
    +    protected List<Predicate<? super T>> constraints;
    --- End diff --
    
    This is persisted so should be extra careful with renames. When passing constraints from
java the caller can wrap them in `and` if multiple, so this change is not needed. Suggest
reverting.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message