brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From neykov <...@git.apache.org>
Subject [GitHub] brooklyn-server pull request #358: Allow REST API to return the pinned confi...
Date Thu, 29 Sep 2016 16:07:11 GMT
Github user neykov commented on a diff in the pull request:

    https://github.com/apache/brooklyn-server/pull/358#discussion_r81173329
  
    --- Diff: camp/camp-brooklyn/src/test/java/org/apache/brooklyn/camp/brooklyn/catalog/SpecParameterParsingTest.java
---
    @@ -66,19 +66,20 @@ public void testYamlInputsParsed() {
                     "    - simple",
                     "    - name: explicit_name",
                     "    - name: third_input",
    -                "      type: integer");
    +                "      type: integer",
    +                "      pinned: true");
             EntitySpec<?> item = mgmt().getTypeRegistry().createSpec(mgmt().getTypeRegistry().get(itemId),
null, EntitySpec.class);
             List<SpecParameter<?>> inputs = item.getParameters();
             assertEquals(inputs.size(), 6);
             SpecParameter<?> firstInput = inputs.get(0);
             assertEquals(firstInput.getLabel(), "simple");
    -        assertEquals(firstInput.isPinned(), true);
    +        assertEquals(firstInput.isPinned(), false);
    --- End diff --
    
    How come the tests still pass with this change? Am I missing something?
    The default is flipped to `true` now, so the change shouldn't be needed?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message