brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From neykov <...@git.apache.org>
Subject [GitHub] brooklyn-server pull request #358: Allow REST API to return the config key's...
Date Thu, 29 Sep 2016 12:28:03 GMT
Github user neykov commented on a diff in the pull request:

    https://github.com/apache/brooklyn-server/pull/358#discussion_r81124282
  
    --- Diff: rest/rest-resources/src/main/java/org/apache/brooklyn/rest/transform/EntityTransformer.java
---
    @@ -162,7 +163,7 @@ public static EntityConfigSummary entityConfigSummary(Entity entity,
ConfigKey<?
                 SensorTransformer.addNamedAction(lb, na, entity.getConfig(config), config,
entity);
             }
         
    -        return entityConfigSummary(config, label, priority, lb.build());
    +        return entityConfigSummary(config, label, priority, false, lb.build());
    --- End diff --
    
    This will mark all config as invisible in `v1/applications/xxxxxxxx/entities/yyyyyyyy/config`.
That's fine as long as the UI know about this caveat. Might be better to make this field nullable
and set `null` here?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message