brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bostko <...@git.apache.org>
Subject [GitHub] brooklyn-library pull request #64: BROOKLYN-350 Curl will follow location re...
Date Mon, 26 Sep 2016 14:15:13 GMT
Github user bostko commented on a diff in the pull request:

    https://github.com/apache/brooklyn-library/pull/64#discussion_r80484187
  
    --- Diff: software/database/src/main/java/org/apache/brooklyn/entity/database/postgresql/PostgreSqlNode.java
---
    @@ -52,13 +52,17 @@
     public interface PostgreSqlNode extends SoftwareProcess, HasShortName, DatastoreCommon,
DatabaseNode {
         
         @SetFromFlag("version")
    -    ConfigKey<String> SUGGESTED_VERSION = ConfigKeys.newConfigKeyWithDefault(SoftwareProcess.SUGGESTED_VERSION,
"9.3-1");//"9.1-4");
    +    ConfigKey<String> SUGGESTED_VERSION = ConfigKeys.newConfigKeyWithDefault(SoftwareProcess.SUGGESTED_VERSION,
"9.3-3");//"9.1-4");
     
         @SetFromFlag("configFileUrl")
         ConfigKey<String> CONFIGURATION_FILE_URL = ConfigKeys.newStringConfigKey(
                 "postgresql.config.file.url", "URL where PostgreSQL configuration file can
be found; "
                     + "if not supplied the blueprint uses the default and customises it");
     
    +    @SetFromFlag("curlCommand")
    +    ConfigKey<String> CURL_COMMAND = ConfigKeys.newStringConfigKey(
    +            "curl.command", "CURL comamnd with parameters to be used", "curl -L");
    --- End diff --
    
    Could you rename it to `cURL`.
    Could you try adding more info on this parameter?



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message