brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ahgittin <...@git.apache.org>
Subject [GitHub] brooklyn-server pull request #331: Fix some memory leaks and better memory u...
Date Mon, 26 Sep 2016 09:40:37 GMT
Github user ahgittin commented on a diff in the pull request:

    https://github.com/apache/brooklyn-server/pull/331#discussion_r80437744
  
    --- Diff: camp/camp-base/src/main/java/org/apache/brooklyn/camp/spi/collection/BasicResourceLookup.java
---
    @@ -43,6 +47,11 @@ public synchronized void add(T item) {
             if (old!=null) {
                 items.put(old.getId(), old);
                 throw new IllegalStateException("Already contains item for "+item.getId()+":
"+old+" (adding "+item+")");
    --- End diff --
    
    agree doesn't make much sense -- have added a TODO comment (as wasn't introduced here
and don't want to change, even though i'm pretty sure it's safe)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message