brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ahgittin <...@git.apache.org>
Subject [GitHub] brooklyn-server issue #330: TypeCoerce string to byte[]
Date Thu, 22 Sep 2016 12:07:18 GMT
Github user ahgittin commented on the issue:

    https://github.com/apache/brooklyn-server/pull/330
  
    @neykov that impl isn't a true superset is it?  it looks at ";" if supplied and does magic
with that according to the spec of the `data` protocol.  i don't think that would be appropriate
here.
    
    @aledsage the code is fine but i question the use case.  why would an effector take `byte[]`
if a string is a sensible thing for a person to supply.  if that's pressing we could introduce
a new type `CoercibleFromByteArrayOrString` or give multiple input parameters on the effector.
    
    this type of low-level coercion feels risky as @geomacy says, even by my standards!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message