brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ahgittin <...@git.apache.org>
Subject [GitHub] brooklyn-server pull request #340: ConfigMap refactor, respecting inheritanc...
Date Thu, 22 Sep 2016 09:04:30 GMT
Github user ahgittin commented on a diff in the pull request:

    https://github.com/apache/brooklyn-server/pull/340#discussion_r80000143
  
    --- Diff: camp/camp-brooklyn/src/test/java/org/apache/brooklyn/camp/brooklyn/ConfigInheritanceYamlTest.java
---
    @@ -72,6 +72,7 @@ public void setUp() throws Exception {
             
             emptyFile = Files.createTempFile("ConfigInheritanceYamlTest", ".txt");
             emptyFile2 = Files.createTempFile("ConfigInheritanceYamlTest2", ".txt");
    +        emptyFile3 = Files.createTempFile("ConfigInheritanceYamlTest3", ".txt");
    --- End diff --
    
    now using `Os.newTempFile` instead which does deletion (i've also added the explicit deletion
here)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message