brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aledsage <>
Subject [GitHub] brooklyn-server pull request #340: ConfigMap refactor, respecting inheritanc...
Date Thu, 22 Sep 2016 07:17:57 GMT
Github user aledsage commented on a diff in the pull request:
    --- Diff: core/src/main/java/org/apache/brooklyn/core/internal/
    @@ -298,15 +298,20 @@ private static void addPropertiesFromMapSupplier(BrooklynProperties
p, Supplier<
         public <T> T getConfig(HasConfigKey<T> key);
    -    @Override
         public <T> T getConfig(HasConfigKey<T> key, T defaultValue);
    -    @Override
    +    /**
    +     * Returns value stored against the given key,
    +     * resolved (if it is a Task, possibly blocking), and coerced to the appropriate
    +     * or given default value if not set, 
    +     * unless the default value is null in which case it returns the default.
    +     */
         public <T> T getConfig(ConfigKey<T> key, T defaultValue);
    -    @Override
    -    public Object getRawConfig(ConfigKey<?> key);
    +    public Maybe<Object> getConfigRaw(ConfigKey<?> key);
    +    /** Inheritance is ignored here. Preferable to use {@link #getConfigRaw(ConfigKey)}.
    --- End diff --
    Perhaps we should deprecate this method?

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message