brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From neykov <...@git.apache.org>
Subject [GitHub] brooklyn-server pull request #300: Location DSL Updates
Date Wed, 21 Sep 2016 13:33:53 GMT
Github user neykov commented on a diff in the pull request:

    https://github.com/apache/brooklyn-server/pull/300#discussion_r79833570
  
    --- Diff: core/src/main/java/org/apache/brooklyn/entity/group/DynamicFabricImpl.java ---
    @@ -134,29 +125,39 @@ public void start(Collection<? extends Location> locsO) {
                                 it = locationsToStart.get(locIndex++ % locationsToStart.size());
                                 ((EntityInternal)child).addLocations(Arrays.asList(it));
                             }
    -                    
    +
                         tasks.put(child, Entities.submit(this,
    -                        Effectors.invocation(child, START, ImmutableMap.of("locations",

    +                        Effectors.invocation(child, START, ImmutableMap.of("locations",
                                 it==null ? ImmutableList.of() : ImmutableList.of(it))).asTask()));
                     }
                 }
                 // remove all the locations we applied to existing nodes
                 while (locIndex-->0 && !locationsToStart.isEmpty())
                     locationsToStart.remove(0);
     
    -            // finally (and usually) we create new entities for locations passed in
    +            // now look at the configured location specs
    +            List<LocationSpec<?>> locationSpecs = MutableList.copyOf(config().get(LOCATION_SPECS));
    +            if (locationSpecs.size() > 0) {
    +                // use these in addition to locations passed to start method
    +                for (LocationSpec<?> spec : locationSpecs) {
    +                    Location location = getManagementContext().getLocationManager().createLocation(spec);
    +                    locationsToStart.add(location);
    +                }
    --- End diff --
    
    Where are these locations unmanaged?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message