brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From neykov <...@git.apache.org>
Subject [GitHub] brooklyn-server pull request #332: JcloudsLocation: Ability to supply extern...
Date Mon, 19 Sep 2016 05:25:30 GMT
Github user neykov commented on a diff in the pull request:

    https://github.com/apache/brooklyn-server/pull/332#discussion_r79329299
  
    --- Diff: core/src/main/java/org/apache/brooklyn/core/location/cloud/CloudLocationConfig.java
---
    @@ -79,7 +79,10 @@
                 + "if 'false', will default to the node's first public IP (or privae if no
public IPs); "
                 + "if 'true' uses default duration; otherwise accepts a time string e.g.
'5m' (the default) or a number of milliseconds", "5m");
     
    -    public static final ConfigKey<String> WAIT_FOR_SSHABLE = ConfigKeys.newStringConfigKey("waitForSshable",

    +    ConfigKey<String> POLL_FOR_FIRST_REACHABLE_ADDRESS_PREDICATE = ConfigKeys.newStringConfigKey("pollForFirstReachableAddress.predicate",
    --- End diff --
    
    I suggest we change this to two alternative keys:
    * `ConifgKey<Class<? extends Predicate<HostAndPort>>>` `pollForFirstReachableAddress.predicate.type`
    * `ConfigKey<Predicate<HostAndPort>>` `pollForFirstReachableAddress.predicate`
    
    Coercion will take care of converting a string to the first key if that's what we got.
DSL can be used to create an object for the second. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message