brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From duncangrant <...@git.apache.org>
Subject [GitHub] brooklyn-server pull request #319: Clean up duplicated code in JcloudsLocati...
Date Mon, 05 Sep 2016 12:58:57 GMT
Github user duncangrant commented on a diff in the pull request:

    https://github.com/apache/brooklyn-server/pull/319#discussion_r77518183
  
    --- Diff: locations/jclouds/src/main/java/org/apache/brooklyn/location/jclouds/networking/SharedLocationSecurityGroupCustomizer.java
---
    @@ -72,9 +74,17 @@
          */
         private int[] inboundPorts;
     
    +    private IpProtocol ipProtocol;
    +    private RangeSet<Integer> portRanges;
    --- End diff --
    
    I don't like this.  It makes the yaml more complicated.  If you want to merge the tcpPortRanges
and udpPortRanges then I'd prefer you change it to accept something like:
    portRanges: tcp/22, udp/1000-1100, 8080
    where it defaults to tcp when no protocol set.
    
    Otherwise you'd need to created 2 shared security groups - so that you could configure
both tcp and udp ports.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message