brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From neykov <...@git.apache.org>
Subject [GitHub] brooklyn-server pull request #285: Adding HttpExecutor to be used for interc...
Date Mon, 05 Sep 2016 10:24:36 GMT
Github user neykov commented on a diff in the pull request:

    https://github.com/apache/brooklyn-server/pull/285#discussion_r77501296
  
    --- Diff: core/src/main/java/org/apache/brooklyn/util/http/executor/HttpExecutorFactoryImpl.java
---
    @@ -0,0 +1,75 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing,
    + * software distributed under the License is distributed on an
    + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    + * KIND, either express or implied.  See the License for the
    + * specific language governing permissions and limitations
    + * under the License.
    + */
    +package org.apache.brooklyn.util.http.executor;
    +
    +import java.util.Map;
    +import java.util.Map.Entry;
    +
    +import org.apache.brooklyn.util.collections.MutableMap;
    +import org.apache.brooklyn.util.core.ClassLoaderUtils;
    +import org.apache.brooklyn.util.core.flags.TypeCoercions;
    +import org.apache.brooklyn.util.exceptions.Exceptions;
    +import org.apache.brooklyn.util.http.executor.apacheclient.HttpExecutorImpl;
    +import org.apache.brooklyn.util.text.StringPredicates;
    +import org.apache.brooklyn.util.text.Strings;
    +import org.slf4j.Logger;
    +import org.slf4j.LoggerFactory;
    +
    +import com.google.common.collect.Maps;
    +
    +public class HttpExecutorFactoryImpl implements HttpExecutorFactory {
    +    private static final Logger LOG = LoggerFactory.getLogger(HttpExecutorFactoryImpl.class);
    +
    +    public HttpExecutorFactoryImpl() {
    +        // no-op
    +    }
    +
    +    @Override
    +    public HttpExecutor getHttpExecutor(Map<?, ?> props) {
    +        HttpExecutor httpExecutor;
    +
    +        String httpExecutorClass = (String) props.get(HTTP_EXECUTOR_CLASS);
    +        if (httpExecutorClass != null) {
    +            Map<?, ?> executorProps = Maps.filterKeys(props, StringPredicates.isStringStartingWith(HTTP_EXECUTOR_CLASS_CONFIG_PREFIX));
    +            if (executorProps.size() > 0) {
    +                Map<String, String> httpExecutorProps = MutableMap.of();
    +                for (Entry<?, ?> entry: executorProps.entrySet()) {
    +                    String keyName = Strings.removeFromStart((String)entry.getKey(),
HTTP_EXECUTOR_CLASS_CONFIG_PREFIX);
    +                    httpExecutorProps.put(keyName, TypeCoercions.coerce(entry.getValue(),
String.class));
    --- End diff --
    
    Why force all executor params to be strings?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message