brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ygy <...@git.apache.org>
Subject [GitHub] brooklyn-server pull request #285: Adding HttpExecutor to be used for interc...
Date Fri, 02 Sep 2016 17:43:16 GMT
Github user ygy commented on a diff in the pull request:

    https://github.com/apache/brooklyn-server/pull/285#discussion_r77385034
  
    --- Diff: core/src/main/java/org/apache/brooklyn/feed/http/HttpFeed.java ---
    @@ -275,7 +294,23 @@ public HttpFeed() {
         protected HttpFeed(Builder builder) {
             setConfig(ONLY_IF_SERVICE_UP, builder.onlyIfServiceUp);
             Map<String,String> baseHeaders = ImmutableMap.copyOf(checkNotNull(builder.headers,
"headers"));
    -        
    +
    +        HttpExecutor httpExecutor;
    +        if (builder.httpExecutor != null) {
    +            httpExecutor = builder.httpExecutor;
    +        } else {
    +            HttpExecutorFactory httpExecutorFactory = null;
    +            Collection<? extends Location> locations = Locations.getLocationsCheckingAncestors(builder.entity.getLocations(),
builder.entity);
    +            Maybe<Location> location =  Machines.findUniqueElement(locations, Location.class);
    --- End diff --
    
    Addressed. `MachineLocation` is used to cover windows entities too.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message