brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From neykov <...@git.apache.org>
Subject [GitHub] brooklyn-server pull request #310: Child entity customizer
Date Thu, 01 Sep 2016 08:37:41 GMT
Github user neykov commented on a diff in the pull request:

    https://github.com/apache/brooklyn-server/pull/310#discussion_r77134670
  
    --- Diff: locations/jclouds/src/main/java/org/apache/brooklyn/location/jclouds/SudoTtyFixingCustomizer.java
---
    @@ -30,19 +30,15 @@
     /**
      * Wraps Brooklyn's sudo-tty mitigations in a {@link JcloudsLocationCustomizer} for easy(-ish)
consumption
      * in YAML blueprints:
    + * <pre>{@code
    + * name: My App
    + * brooklyn.config:
    + *   provisioning.properties:
    + *     customizerType: SudoTtyFixingCustomizer
    + * }</pre>
    + * This class should be seen as a temporary workaround and might disappear completely
if/when Brooklyn takes care of this automatically.
      *
    - * <pre>
    - *   name: My App
    - *   brooklyn.config:
    - *     provisioning.properties:
    - *       customizerType: SudoTtyFixingCustomizer
    - *   services: ...
    - * </pre>
    - *
    - * <p>This class should be seen as a temporary workaround and might disappear completely
if/when Brooklyn takes care of this automatically.
    - *
    - * <p>See
    - * <a href='http://unix.stackexchange.com/questions/122616/why-do-i-need-a-tty-to-run-sudo-if-i-can-sudo-without-a-password'>http://unix.stackexchange.com/questions/122616/why-do-i-need-a-tty-to-run-sudo-if-i-can-sudo-without-a-password</a>
    + * @see <a href='http://unix.stackexchange.com/questions/122616/why-do-i-need-a-tty-to-run-sudo-if-i-can-sudo-without-a-password'>http://unix.stackexchange.com/questions/122616/why-do-i-need-a-tty-to-run-sudo-if-i-can-sudo-without-a-password</a>
    --- End diff --
    
    Btw this is already part of `JcloudsLocation`. Should we deprecate this now? Any use-cases
where the location config can't be used?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message