Mailing-List: contact dev-help@brooklyn.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@brooklyn.apache.org
From: sjcorbett <git@git.apache.org>
To: dev@brooklyn.apache.org
Reply-To: dev@brooklyn.apache.org
References: <git-pr-299-brooklyn-server@git.apache.org>
In-Reply-To: <git-pr-299-brooklyn-server@git.apache.org>
Subject: [GitHub] brooklyn-server pull request #299: fix extra ssh key data
Content-Type: text/plain
Message-Id: <20160815140322.811E3E01E2@git1-us-west.apache.org>
Date: Mon, 15 Aug 2016 14:03:22 +0000 (UTC)
archived-at: Mon, 15 Aug 2016 14:03:24 -0000

Github user sjcorbett commented on a diff in the pull request:

    https://github.com/apache/brooklyn-server/pull/299#discussion_r74765479
  
    --- Diff: locations/jclouds/src/main/java/org/apache/brooklyn/location/jclouds/JcloudsLocation.java ---
    @@ -1013,10 +1013,22 @@ protected MachineLocation obtainOnce(ConfigBag setup) throws NoMachinesAvailable
                             }
                             executeCommandThrowingOnError(
                                     (SshMachineLocation)machineLocation,
    -                                "Authorizing ssh keys",
    +                                "Authorizing ssh keys from URLs",
                                     ImmutableList.of(new AuthorizeRSAPublicKeys(extraKeyDataToAuth).render(org.jclouds.scriptbuilder.domain.OsFamily.UNIX)));
                         }
                     }
    +                
    +                String extraKeyDataToAuth = setup.get(EXTRA_PUBLIC_KEY_DATA_TO_AUTH);
    +                if (extraKeyDataToAuth!=null && !extraKeyDataToAuth.isEmpty()) {
    +                    if (windows) {
    +                        LOG.warn("Ignoring flag EXTRA_PUBLIC_KEY_DATA_TO_AUTH on Windows location", machineLocation);
    --- End diff --
    
    It would be great if there were some way to communicate these messages to the user/tool doing the deployment. Or even to raise it before deployment.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---