brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From neykov <...@git.apache.org>
Subject [GitHub] brooklyn-server pull request #276: Effector for opening inbound ports in sec...
Date Tue, 23 Aug 2016 12:41:56 GMT
Github user neykov commented on a diff in the pull request:

    https://github.com/apache/brooklyn-server/pull/276#discussion_r75856867
  
    --- Diff: software/base/src/main/java/org/apache/brooklyn/entity/software/base/SoftwareProcess.java
---
    @@ -147,6 +147,9 @@
         @SetFromFlag("runDir")
         AttributeSensorAndConfigKey<String,String> RUN_DIR = BrooklynConfigKeys.RUN_DIR;
     
    +    ConfigKey<Boolean> ADD_OPEN_PORTS_EFFECTOR = ConfigKeys.newBooleanConfigKey("effector.add.openPorts",
    --- End diff --
    
    My idea was that the class `AddEffector` is a generic way to attach effectors to entities
in yaml. Then no need for an ad-hoc flag to attach the effector.
    Looking at the implementation though it's not straightforward to use it in YAML currently
so ignore.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message