brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From grkvlt <...@git.apache.org>
Subject [GitHub] brooklyn-server pull request #304: Adds a target configuration to the SSH co...
Date Mon, 22 Aug 2016 14:25:05 GMT
Github user grkvlt commented on a diff in the pull request:

    https://github.com/apache/brooklyn-server/pull/304#discussion_r75686795
  
    --- Diff: core/src/main/java/org/apache/brooklyn/enricher/stock/Enrichers.java ---
    @@ -293,42 +307,33 @@ protected String getDefaultUniqueTag() {
                 return "aggregator:"+publishing.getName();
             }
             public EnricherSpec<?> build() {
    -            Predicate<Object> valueFilter;
    --- End diff --
    
    No, it's OK, this is actually fixing broken (although mostly working) code. The code now
properly configures the enricher with the passed in `excludingBlank` and `valueFilter` values,
and the aggregators that use this functionality manage the configuration of the filter themselves
(see `getDefaultVlaueFilter()` method in `Aggregator.java` and the line in `AbstracxtAggregator.java`
in `setEntityLoadingConfig()` which uses this to set the `valueFilter` field.) It might be
useful to have a check that one of the two config keys, `EXCLUDING_BLANK` or `VALUE_FILTER`
is set, though.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message