brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From neykov <...@git.apache.org>
Subject [GitHub] brooklyn-server pull request #285: Adding HttpExecutor to be used for interc...
Date Mon, 22 Aug 2016 14:15:07 GMT
Github user neykov commented on a diff in the pull request:

    https://github.com/apache/brooklyn-server/pull/285#discussion_r75684986
  
    --- Diff: core/src/main/java/org/apache/brooklyn/core/location/LocationConfigKeys.java
---
    @@ -35,7 +35,9 @@
         public static final ConfigKey<String> DISPLAY_NAME = ConfigKeys.newStringConfigKey("displayName");
         public static final ConfigKey<Boolean> ENABLED = ConfigKeys.newBooleanConfigKey("enabled",
"Whether the location is enabled for listing and use "
             + "(only supported for selected locations)", true);
    -    
    +
    +    public static final ConfigKey<String> EXTENSION = ConfigKeys.newStringConfigKey("extension");
    --- End diff --
    
    Better make it Map<String, Object> to
      * allow multiple extensions to be registered
      * use $brooklyn:object to construct the extensions (though brooklyn DSL doesn't work
too well in location config). If it's a string then could treat it as class name and instantiate
it. 
    
    wdyt?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message