brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ahgittin <>
Subject [GitHub] brooklyn-server pull request #304: Adds a target configuration to the SSH co...
Date Mon, 22 Aug 2016 07:45:53 GMT
Github user ahgittin commented on a diff in the pull request:
    --- Diff: core/src/main/java/org/apache/brooklyn/enricher/stock/ ---
    @@ -293,42 +307,33 @@ protected String getDefaultUniqueTag() {
                 return "aggregator:"+publishing.getName();
             public EnricherSpec<?> build() {
    -            Predicate<Object> valueFilter;
    --- End diff --
    won't removing this break every aggregator which relies on `valueFilter` to deliver `excludingBlank`
    is it better to keep the if block and fail if both value-filter and excluding blank are
set (or construct a new `and` filter) ?

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message