brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ahgittin <...@git.apache.org>
Subject [GitHub] brooklyn-server pull request #304: Adds a target configuration to the SSH co...
Date Mon, 22 Aug 2016 07:39:37 GMT
Github user ahgittin commented on a diff in the pull request:

    https://github.com/apache/brooklyn-server/pull/304#discussion_r75629783
  
    --- Diff: core/src/main/java/org/apache/brooklyn/core/entity/AbstractEntity.java ---
    @@ -196,7 +196,11 @@
                 "entity.group.added", "Group dynamically added to entity");
         public static final BasicNotificationSensor<Group> GROUP_REMOVED = new BasicNotificationSensor<Group>(Group.class,
                 "entity.group.removed", "Group dynamically removed from entity");
    -    
    +
    +    public static final AttributeSensor<String> ENTITY_ID = Attributes.ENTITY_ID;
    +    public static final AttributeSensor<String> APPLICATION_ID = Attributes.APPLICATION_ID;
    +    public static final AttributeSensor<String> CATALOG_ID = Attributes.CATALOG_ID;
    --- End diff --
    
    why make these sensors?  is there a better way to achieve whatever the goal is?
    
    this info is already present as fields and it seems to me a bit of a smell to put the
same data in multiple places.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message