brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From duncangrant <...@git.apache.org>
Subject [GitHub] brooklyn-server pull request #292: Shared location customizer
Date Thu, 11 Aug 2016 20:06:04 GMT
Github user duncangrant commented on a diff in the pull request:

    https://github.com/apache/brooklyn-server/pull/292#discussion_r74493342
  
    --- Diff: locations/jclouds/src/main/java/org/apache/brooklyn/location/jclouds/networking/SharedLocationSecurityGroupCustomizer.java
---
    @@ -0,0 +1,172 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing,
    + * software distributed under the License is distributed on an
    + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    + * KIND, either express or implied.  See the License for the
    + * specific language governing permissions and limitations
    + * under the License.
    + */
    +package org.apache.brooklyn.location.jclouds.networking;
    +
    +import java.util.List;
    +
    +import javax.annotation.Nullable;
    +
    +import org.apache.brooklyn.location.jclouds.BasicJcloudsLocationCustomizer;
    +import org.apache.brooklyn.location.jclouds.JcloudsLocation;
    +import org.apache.brooklyn.location.jclouds.JcloudsMachineLocation;
    +import org.apache.brooklyn.util.core.BrooklynNetworkUtils;
    +import org.apache.brooklyn.util.net.Cidr;
    +import org.jclouds.compute.ComputeService;
    +import org.jclouds.compute.domain.Template;
    +import org.jclouds.compute.options.TemplateOptions;
    +import org.jclouds.net.domain.IpPermission;
    +import org.jclouds.net.domain.IpProtocol;
    +
    +import com.google.common.base.Function;
    +import com.google.common.base.Strings;
    +import com.google.common.base.Suppliers;
    +import com.google.common.collect.FluentIterable;
    +import com.google.common.collect.Range;
    +import com.google.common.collect.RangeSet;
    +
    +/**
    + * Configures a shared security group on Jclouds locations
    + * <p>
    + * Is based on {@link JcloudsLocationSecurityGroupCustomizer} but can be instantiated
    + * in yaml e.g.
    + * <p>
    + * services:
    + * - type: org.apache.brooklyn.entity.software.base.EmptySoftwareProcess
    + * brooklyn.config:
    + * provisioning.properties:
    + * customizers:
    + * - $brooklyn:object:
    + * type: org.apache.brooklyn.location.jclouds.networking.SharedLocationSecurityGroupCustomizer
    + * object.fields: {locationName: "test", portRanges: ["900-910","915", "22"], cidr: "82.40.153.101/24"}
    + */
    +public class SharedLocationSecurityGroupCustomizer extends BasicJcloudsLocationCustomizer
{
    --- End diff --
    
    I don't think there is anything worth pushing into JcloudsLocationSecurityGroupCustomizer.
 I would have like to just modify it to have a no args constructor that would let us work
with it in yaml but couldn't quite see a way to do it without changing its behaviour.
    
    It tries to be idempotent but then it also seems to catch (and ignore) the error if it
does try to add a range a second time so possibly that can happen but I can't see where.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message